Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 --- Comment #4 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- * BuildRequires - srpm rebuilt from your spec file won't build on koji F20. Please add appropriate BuildRequires (at least rubygem-devel is needed) * Documentation etc - Please mark AUTHORS CHANGES COPYING README.md %{gem_docdir} as %doc (at least COPYING must be marked as %doc) - INSTALLING file is not needed as installing is done by rpm - Also Rakefile is not needed as Rakefile is like Makefiles in autotools based files, which we do not package into binary rpms. - It is recommended to split out %gem_docdir into -doc rpm. - test/ directory should not be packaged into binary rpm: https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites * Virtual Requires - For (Build)Requires, please use "Requires: rubygem(hpricot)" style instead of directly writing rpms' names (i.e. instead of "Requires: rubygem-hpricot") so as to be consistent of other packages. * Running test suites - As this gem contains test/ directory, please add %check seciton and execute some test program in %check: https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3go7SJRz5v&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review