[Bug 923564] Review Request: NetworkManager-ssh - NetworkManager VPN plugin for SSH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=923564

--- Comment #31 from Dan Fruehauf <malkodan@xxxxxxxxx> ---
(In reply to comment #30)
> (In reply to comment #29)
> > Pavel,
> > 
> > You've followed up in the NetworkManager mailing list, however I want to
> > make sure the issue is clear.
> > 
> > Even if we patch NetworkManager - yes or no, we'll still have to suggest the
> > user to restart NetworkManager. If the user will have to restart
> > NetworkManager, do we really want the patch?
> 
> Sure we do. It fixes the problem at least with the restart.
> 
Not exactly.
> > In future versions if the patch is not applied and the NetworkManager-ssh
> > package is downloaded after NetworkManager and the patch was not applied, a
> > restart will be needed. If the patch would be applied - it wouldn't require
> > a restart.
> 
> Please elaborate. This way you're only adding more confusion. Please be more
> precise. It looks like your contradicting yourself blatantly which suggests
> there's some misunderstanding.
> 
> > If someone does not perform a distribution upgrade (f18 for instance) and
> > updates NetworkManager with the patch and downloads NetworkManager-ssh -
> > things will not work until a restart of NetworkManager.
> > 
> > In my opinion the patch should be applied regardless, since all the known
> > VPN plugins are recognized in NetworkManager dbus config file, however much
> > of a difference it doesn't make since the current limitations will require a
> > restart in some cases. It wouldn't be "clean".
> 
> From the current information I have, we're choosing between:
> 
> a) It will work after restart
> b) It will not work at all
> 
> Corrent me if I'm wrong. And also correct the information you provided. As
> in this situation I'm of course for #a as it will allow me to use the
> package, while #b won't.
> 
> > Please advise what you think is the best solution.
> 
> I'm afraid that if you are even thinking about not applying the patch, then
> there must be some confusion that you should clarify first. I can't imagine
> why would you want to deliver a package that doesn't work.

In terms of dbus policy, every NetworkManager VPN plugin ships:
/etc/dbus-1/system.d/nm-X-service.conf
In our case:
/etc/dbus-1/system.d/nm-ssh-service.conf
These files include the line:
---
<allow send_destination="org.freedesktop.NetworkManager.ssh"/>
---

However these lines are also in
/etc/dbus-1/system.d/org.freedesktop.NetworkManager.conf - which ships with
NetworkManager:
---
<allow send_destination="org.freedesktop.NetworkManager.ssh"/>
---

So every plugin theoretically takes care of itself. However if you install a
new plugin, its policy (in /etc/dbus-1/system.d/nm-X-service.conf) will not be
used until NetworkManager is restarted, this is the dbus bug we were referring
to.

Having this line in the NetworkManager dbus config
(/etc/dbus-1/system.d/org.freedesktop.NetworkManager.conf) as a dup for that
just means that if NetworkManager is running and you add a new VPN plugin -
it'll work without a restart (because it loaded the config allowing all VPN
plugins).

I hope this time I've made more sense... :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jOqLIk5Jpt&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]