[Bug 929189] Review Request: python-flask-script - Scripting support for Flask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=929189

--- Comment #2 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> ---
- python_sitelib and python_sitearch definitions aren't needed any more, please
remove them.
- "rm -rf $RPM_BUILD_ROOT" in %install is not needed either
- rpmlint reports a tiny problem about mixed spaces/tabs - certainly not a
blocker but please fix it to silence rpmlint:
python-flask-script.src:21: W: mixed-use-of-spaces-and-tabs (spaces: line 21,
tab: line 6)
- I don't think including the whole docs/ directory makes much sense. If look
at its contents, these are sphinx [1] documentation sources, not a generated
documentation. Therefore, I would suggest using sphinx to create html (cd docs
&& make html) and including the html directory in %docs (it will be something
like docs/_build/html).
- PKG-INFO shouldn't be included in %docs, it's not intended to be a
documentation file.

[1] http://sphinx-doc.org/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NOrS5vRwD8&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]