Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947071 --- Comment #1 from Volker Fröhlich <volker27@xxxxxx> --- According to the files, the license is GPLv2+. This seems to be a noarch package and should be labeled accordingly. Use the name macro for your other sources as well. You must BR systemd, according to http://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations Take a look at the Perl guidelines on how and if to require Perl modules manually. I think you should create a monitorix system user. The logrotate file doesn't match the actual file and directory layout. It should also have a su line. Your package should either own %{_sysconfdir}/logrotate.d/ or require logrotate "rm -rf %{buildroot}" in the install section should be dropped, as it is no longer necessary. %{_localstatedir}/lib/monitorix/reports/*.html -- You're not owning this directory. I also wonder why html should be configuration. Replace the ".gz" from the manpages with an asterisk, to allow for the compression method to change. What's the point of 777 permissions for that one directory? Your changelog entry has an invalid form. See http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs As a sidenote, you could shorten your install section by using the -D option of the install command. You must also use -p to preserve the timestamps. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e0yYOAvpAQ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review