Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909471 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |misc@xxxxxxxx --- Comment #14 from Michael Scherer <misc@xxxxxxxx> --- For sure, we can get without the tests, but given the changing nature of ruby, I strongly recommend to have them enabled later and try to spend sometime on having a way to make them work. I will see if I can provide a patch for that. Anyway, I am not up to date regarding the changes to the ruby packaging policy, but there is a item in fedora review for : "Gem package should exclude cached Gem." So can you exclude the cache from the %files list ? https://fedoraproject.org/wiki/Packaging_talk:Ruby#Cached_.gem_file Another issue is the requires. The gemspec talk of The spec say : Requires: %{?scl:%scl_prefix}rubygems Requires: %{?scl:%scl_prefix}rubygem(json) Requires: %{?scl:%scl_prefix}rubygem(rails) Requires: rubygem(openshift-origin-common) Requires: rubygem(openshift-origin-controller) Requires: openshift-origin-broker Gemspec only speak of : s.add_dependency('openshift-origin-controller') s.add_dependency('json') After looking at the code, there is no need for the json module ( except for test ). It seems I forgot to make PR for that after seeing 6 months ago : https://github.com/mscherer/origin-server/commit/982375a196d11f887097c751189e032ccdfa9700 Anyway, this package should be good, provided thse 2 minors changes are fixed so approved. Package Review ============== Key: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed [!]: Gem package should exclude cached Gem. [!]: No need to requires ruby json ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /var/www/openshift [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem- openshift-origin-auth-remote-user-doc [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [x]: Platform dependent files must all go under %{gem_extdir}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Pure Ruby package must be built as noarch [x]: Package contains Requires: ruby(abi). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [!]: Gem package should exclude cached Gem. [!]: Test suite of the library should be run. [x]: Specfile should use macros from rubygem-devel package. Note: The specfile doesn't use these macros: %{gem_libdir}, %exclude %{gem_cache} ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rubygem-openshift-origin-auth-remote-user-1.5.6-2.fc18.noarch.rpm rubygem-openshift-origin-auth-remote-user-doc-1.5.6-2.fc18.noarch.rpm rubygem-openshift-origin-auth-remote-user-doc.noarch: W: non-conffile-in-etc /etc/openshift/plugins.d/openshift-origin-auth-remote-user.conf.example 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint rubygem-openshift-origin-auth-remote-user rubygem-openshift-origin-auth-remote-user-doc rubygem-openshift-origin-auth-remote-user-doc.noarch: W: non-conffile-in-etc /etc/openshift/plugins.d/openshift-origin-auth-remote-user.conf.example 2 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- rubygem-openshift-origin-auth-remote-user (rpmlib, GLIBC filtered): /bin/sh openshift-origin-broker ruby(abi) rubygem(json) rubygem(openshift-origin-common) rubygem(openshift-origin-controller) rubygem(rails) rubygems rubygem-openshift-origin-auth-remote-user-doc (rpmlib, GLIBC filtered): /usr/bin/env Provides -------- rubygem-openshift-origin-auth-remote-user: rubygem(openshift-origin-auth-remote-user) rubygem-openshift-origin-auth-remote-user rubygem-openshift-origin-auth-remote-user-doc: rubygem-openshift-origin-auth-remote-user-doc MD5-sum check ------------- http://mirror.openshift.com/pub/openshift-origin/source/rubygem-openshift-origin-auth-remote-user/openshift-origin-auth-remote-user-1.5.6.gem : CHECKSUM(SHA256) this package : 83f8017b9dcd79811680c7b3d3dbc45fed32e1646cbf93a198ff1d384d7883ea CHECKSUM(SHA256) upstream package : 83f8017b9dcd79811680c7b3d3dbc45fed32e1646cbf93a198ff1d384d7883ea Generated by fedora-review 0.4.0 (cf29f98) last change: 2013-02-08 Buildroot used: fedora-18-x86_64 Command line :./try-fedora-review -b 909471 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f6p85LMIVb&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review