Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910233 --- Comment #5 from Ralph Bean <rbean@xxxxxxxxxx> --- All three of your notes are spot on, I think. I've created another update which addresses each of them. - I corrected the version string (I also pulled the latest package from upstream for March -- April has not yet been released). - I changed the datadir directory from geoip/ to GeoIP/. From a review of[1] it seems like co-ownership is appropriate. - I fixed the timestamps, too. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function Spec URL: http://threebean.org/rpm/geoip-geolite.spec SRPM URL: http://threebean.org/rpm/geoip-geolite-2013.03-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fZP3smxHIo&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review