Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928061 Antonio Trande <anto.trande@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anto.trande@xxxxxxxxx --- Comment #1 from Antonio Trande <anto.trande@xxxxxxxxx> --- Hi Nikita. - Source contains code released with GPLv2+ licensing; LICENSE file is a GPLv2; 'Nagstamon/Server/Multisite.py' file says: >...you can redistribute it and/or modify it ># under the terms of the GNU General Public License as published by ># the Free Software Foundation in version 2. ... 'nagstamon' should be released with GPLv2+ licensing. - I think it's sufficient: %install %{__python} setup.py install --skip-build --root %{buildroot} - In my opinion, after %install section all tasks need a short comment that explains why they are necessary. For instance: ## Fix 'non-executable-script' error chmod +x %{buildroot}%{python_sitelib}/Nagstamon/Server/Multisite.py - "Your package should own all of the files that are installed as part of the %install process." http://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership '%{python_sitelib}/Nagstamon' directory must be own of the package. - " The package must be consistent. For any given path, within the same spec, use either a hard-coded path or a macro, not a combination of the two. " https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#macros I think you can uniform better %{name} macro. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ArWD9BoVhh&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review