[Bug 863836] Review Request: NetworkManager-strongswan - NetworkManager VPN plugin for strongSwan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=863836

--- Comment #14 from Pavel Šimerda <psimerda@xxxxxxxxxx> ---
(In reply to comment #13)
> (In reply to comment #12)
> > I hope you're on vacation
> 
> No, this sometimes strange concept of "real life" demanded a bit more
> attention than usually in the past few weeks ;-) But honestly, looking into
> this was definitely on my todo list for Easter :-)

No problem, I just wanted to make sure my delay wasn't fatal.

> > and didn't lose interest.
> 
> No -- but I'm wondering if it would be better for everyone if you would
> maintain this package. But we can change that after the review if we want to.

First of all, you saw how long it took me to do the review. And it's easier
than that. You can share the maintainance burden by granting git push access to
other fedora folks and still be the owner of the package. Likewise you can get
git push access to some of my related packages if you are interested.

> > Looking forward to your answers and finishing the review.
> 
> Here we go:
> 
> (In reply to comment #11)
> >
> > Please fix the review request so that the spec file is the same as the one
> > in the SRPM.
> 
> Argh, sorry, that was a small last minute change. And I really need to look
> properly into the selinux issue, that's why I'm not uploading a new package
> yet.

So when the selinux issue is over, the dbus policy issue is sorted and the
strongswan dependency is changed, the software should work and should be ready
for distribution. I think a good idea would be to target rawhide, f19 and
optinally f18. It's up to you.

> > Please consider notifying upstream about the unversioned .so
> > file and ask them if they would provide properly versioned one.
> 
> Hmmmm. I got the impression unversioned .so files are a normal thing for NM
> after running this:
> 
> [thl@thl-t420 tmp]$ repoquery -ql NetworkManager-openconnect
> NetworkManager-openswan NetworkManager-openswan NetworkManager-openvpn
> NetworkManager-pptp NetworkManager-vpnc NetworkManager-wimax  | grep
> /usr/lib64/NetworkManager/
> /usr/lib64/NetworkManager/libnm-openconnect-properties.so
> /usr/lib64/NetworkManager/libnm-openswan-properties.so
> /usr/lib64/NetworkManager/libnm-openvpn-properties.so
> /usr/lib64/NetworkManager/libnm-pptp-properties.so
> /usr/lib64/NetworkManager/libnm-vpnc-properties.so
> /usr/lib64/NetworkManager/libnm-device-plugin-wimax.so
> [thl@thl-t420 tmp]$

Agreed. No action is needed then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V3OPIhNuT2&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]