Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923564 --- Comment #17 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Dan. I think the best way we can proceed is to first bring this package to the devel branch, aka rawhide or f19, and then open the bug against f18, You can always ask a package change request, requesting a new branch About the latest comments, regarding the package: (In reply to comment #12) > Fixed (it was the order, yes?) Indeed > > - You provide this patch > > %{_datadir}/gnome-vpn-properties/ssh, > Which patch? I'm sorry for the typo s/patch/path, ;) > A bit of a confusion about the changelog in the spec. > Say I have revision X which is last for the changelog, however revision Y, > which is newer is the version I want to build, if I build revision Y and the > last entry is revision X, rpmlint complains about it. > Hence I assume that in the changelog, the last entry should be of the commit > I currently build (which doesn't make any sense, because it's not the last > commit the spec was changed), correct me if I'm wrong. > So I've included an entry of: > '* Thu Mar 28 2013 Dan Fruehauf <malkodan@xxxxxxxxx> - 0.0.3-0.4.%{checkout}' > Any other entry will result in a rpmlint yielding an error. Please clarify > that issue for me. Let's go to the list of commits https://github.com/danfruehauf/NetworkManager-ssh/commits/master the two latest commits are 1af74fd6251eb031dc33753d35c230b98a34ec21 and ccf99d29a55b3090603c6266906142bc513de1c0 The fedora package maintainers, must try and as far as possible to package the latest version of the package which owns. So, if you have something like this %global commit 1af74fd6251eb031dc33753d35c230b98a34ec21 %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global checkout 20130328git%{shortcommit} the changelog should be * Thu Mar 28 2013 Dan Fruehauf <malkodan@xxxxxxxxx> - 0.0.3-0.4.20130328git1af74fd - Fixed more issues in spec to conform with Fedora Packaging standards respecting the snapshot taken. Now in fact, the last commit you have in your git is ccf99d29a55b3090603c6266906142bc513de1c0 so your spec should look like this %global commit ccf99d29a55b3090603c6266906142bc513de1c %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global checkout 20130329git%{shortcommit} and the changelog * Thu Mar 29 2013 Dan Fruehauf <malkodan@xxxxxxxxx> - 0.0.3-0.5.20130329gitccf99d2 - New comment about the changes. Btw, althought 0.0.3-0.4.%{checkout} is an elegant solution, is not allowed because in the changelog, macros are not acceptable check it rpmlint -iv NetworkManager-ssh-0.0.3-0.4.20130328git1af74fd.fc20.src.rpm NetworkManager-ssh.src: I: checking NetworkManager-ssh.src: I: checking-url https://github.com/danfruehauf/NetworkManager-ssh (timeout 10 seconds) NetworkManager-ssh.src:67: W: macro-in-%changelog %{checkout} Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. NetworkManager-ssh.src: I: checking-url https://github.com/danfruehauf/NetworkManager-ssh/archive/1af74fd6251eb031dc33753d35c230b98a34ec21/NetworkManager-ssh-0.0.3-1af74fd.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. > Speaking of which, if you've found so many errors here, are you aware of the > status of NetworkManager and all of the rest of its plugins? Yes, I am aware, so I invite you to open new bugs against these packages that have these issues, once you are maintainer (non limiting) even you can do right now if you want. Let me know what is your decision on the branch you're going to take initially, outside the small changes that I suggest in this comment, I see the package acceptable for a formal review Cheers -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bZhX9H3BL1&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review