Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=865977 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #7 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Good. The README confirms now that the whole thing is a GPLv3+ project that has copied/merged some GPLv2+ files. > I'm not sure if you mean "V=1" should be permanently in the spec file, > or just temporary, for testing. Keeping it in the spec file permanently makes it possibly to analyze build.log files in koji manually or with automated scripts. And if a build fails, verbose build output can be helpful, too. > # libsigrokdecode.h includes <Python.h> > Requires: python3-devel You're free to use Requires: python3-devel%{?_isa} here, because for non-virtual packages, these %_isa Provides are added automatically. $ repoquery --whatprovides 'python3-devel(x86-64)' python3-devel-0:3.3.0-10.fc19.x86_64 > # The pyhton files are designed to work with a python module that only exists s/pyhton/python/ What's left? Some things you're probably aware of already: * %buildroot is emptied automatically at beginning of %install https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag * %defattr is not necessary anymore for https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a1wsyVpwRJ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review