Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 Michal Schmidt <mschmidt@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschmidt@xxxxxxxxxx --- Comment #1 from Michal Schmidt <mschmidt@xxxxxxxxxx> --- Just looking at the spec: - The "Group" tag is optional. You may keep it or drop it. - If possible, use a full URL in Source0. - Please extend %description. - The manual cleaning of the build root at the beginning of %install is redundant. So is the %clean section. - The %check section is empty, so drop it. - %defattr is no longer necessary. - Please maintain a %changelog. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2F89a0WW9O&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review