[Bug 909471] Review Request: rubygem-openshift-origin-auth-remote-user - OpenShift plugin for remote-user authentication

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=909471

--- Comment #8 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
(In reply to comment #7)
> - %{_docdir} docs moved to %{gem_docdir}.

Ups, now I read the .spec file more carefully and get the original idea with
the %{_docdir} and I must say that it was correct idea. Little explanation
would be enough, since I was confused :) However the approach was a bit clumsy.
It should be enough to do:

%install
install -m 644 %{SOURCE1} .

%files
%doc %{name}-doc.README

I apologize for confusion :/

> - vendor - You must have gotten this mixed up with the other openshift
> rubygem.  I couldn't find any directory and/or file with that name in it.
> - %{gem_docdir} and %doc marking - again, I think you have this mixed up
> with the other rubygem spec file.

Sorry, it might be. It was just quick fly through :)

I found another nit: you should use %{_sysconfdir} instead of /etc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DffAQlvce1&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]