Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=844721 --- Comment #21 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> --- - As for the old RPM stuff, I think it's ok if Luis wants to also use this spec on epels (that's for buildroot, clean and defattr). - Django 1.5 compatibility seems to be fine. The spec is running test suite which passes in current Rawhide with Django 1.5. - "python" calls should really be replaced with "%{__python}" - I totally agree with using the homepage that Matthias has suggested. - I appreciate that you sent the pull request with you fix. Could you please put a comment with the pull request url into the specfile? It's good to keep track of these things (so that you can easily see if it was accepted when updating to newer version later). These are really just cosmetic issues. In general, the package is good and once you fix these, it can be approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aKUD1x2I5n&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review