[Bug 923163] Review request: gnome-weather - A Weather application for GNOME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=923163

Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

--- Comment #10 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> ---
--- gnome-weather.spec.bak    2013-03-27 10:37:35.135489201 +0800
+++ gnome-weather.spec    2013-03-26 22:40:29.000000000 +0800
@@ -20,6 +20,11 @@
 # code on an ad-hoc basis.
 Provides:    bundled(libgd)

+# Filter out the libgd.so() provide, since we don't want to possibly
+# satisfy any erroneous dependency on it.
+%filter_provides_in %{_libdir}/%{name}/.*\.so$
+%filter_setup
+
 %description
 gnome-weather is a weather application for GNOME

That fixes my only issue with the package, so I'm approving it.

Just a note for the future: you should bump the Release tag of your spec file
every time you change it, even for the review. It makes it easier for the
reviewer to check changes. (if I hadn't paid attention, I could have
overwritten your previous srpm on my hard drive by downloading the new one,
therefore not being able to compare)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vItVaik3h5&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]