Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785477 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #4 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- MUST [!]: License field in the package spec file matches the actual license. LGPLv2 SHOULD (but worth it as we have a blocker) [!]: Latest version is packaged. [!]: %check is present and all tests pass. version 2.0.4 is relesased which fix tests COULD (not a blocker, really) [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed As Buildroot is removed, both can be removed -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SFUMXgqjvA&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review