Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836840 --- Comment #14 from bebo_sudo <bebo.sudo@xxxxxxxxx> --- Hi Hans, thanks anyway for your answer. I revised my spec and now I think is better than before. spec: http://sourceforge.net/projects/bebosudo-rpms/files/gtkradiant/F18/SRPM/gtkradiant.spec/download srpm: http://sourceforge.net/projects/bebosudo-rpms/files/gtkradiant/F18/SRPM/gtkradiant-1.6.3-20121007.6.fc18.src.rpm/download I've followed your advice and now the source url points at https://github.com/TTimo/GtkRadiant/tarball/master/TTimo-GtkRadiant-6afda55.tar.gz (or whatever value has the shortcommit variable). Now in the %build I use this (http://icculus.org/gtkradiant/documentation/windows_compile_guide/#sources) instructions to build the rpm. The build is made through scons, but, and this is the first doubt, every time I start the rpmbuild process, scons seek and download the whole games archive from the svn server of the project: svn.icculus.org/gtkradiant-gamepacks/ I think isn't normal during the creation of an rpm leave download data from the internet. I think I should make an archive of files and patch the sources to avoid download things from the net, shouldn't I? Look at the config.py: https://github.com/TTimo/GtkRadiant/blob/master/config.py#L274 Here is when the process downloads data from internet. I tried to comment out the two functions to patch the source, but don't think I've done a very clear and complete job. This is my patched version of config.py: http://www.fpaste.org/pOCE/ .. I didn't try it, but could it work? To create the archive containing the games data I suggest to do this: $ mkdir installs/ && cd installs/ $ for game in {Q3,UrT,ET,QL}Pack; do mkdir $game; cd $game; svn checkout svn://svn.icculus.org/gtkradiant-gamepacks/${game}/trunk; mv trunk/* .; rm -r trunk/; cd ../; done; cd .. $ tar -czf gtkradiant-1.6-gamepacks-`date +%Y%m%d`.tar.gz installs/ and add the final tar.gz in the spec like a source, so in the %prep section I can untar it and put in the right place. Is this a possible (and right) way to solve the issue? Another problem.. I discovered that the scons process builds, besides gtkradiant itself, two libraries, libpng and libjpeg. As described in the fp wiki, I shouldn't include bundled libraries in my rpm, so in my spec I removed them in the %install section, but I think I also should remove their creation, to speed up the build. Here is what the upstream said about the embedded libraries: http://icculus.org/pipermail/gtkradiant/2012-September/011823.html --> ".. The slightly less common deps (png and jpeg libraries, some old version) are bundled in to make it simple." How can I avoid the build of unneeded libraries? I think I should edit config.py, around this point (https://github.com/TTimo/GtkRadiant/blob/master/config.py#L251), but I think should be made a deep work on it, which I am not able to do. I've also added the two libraries needed in the Requires tags (libpng12 and libjpeg-turbo), obtained with 'yum provides libpng.so.? libjpeg.so.62', and rpmlint complains these are explicit-lib-dependencies. Is this an issue or should I simply leave Requires: libpng.so.3 Requires: libjpeg.so.62 ? I've also found two right images of gtkradiant, taken from the official server, and I've added them to sources. During the build I've noticed rpmbuild would create strange folders in /usr/lib/debug/blabla.. and so I've added %global debug_package %{nil} at the top of my spec. Is this ok? Besides these problems I tried to install my package in a virtual machine but the problem, which I've already noticed to the upstream (http://icculus.org/pipermail/gtkradiant/2013-February/011841.html) still remains. GtkRadiant would create a folder in the same folder as the launcher, but it doesn't have, rightly, the proper permissions. This a screenshot: http://www.pikky.net/uploads/3f2efd1024371f768dc0c40cce5bbb51872dc5d3.png As Hans noticed, scons and in general all gtkradiant package, are a nasty beast for rpm. Thanks for your attention, Best wishes Alberto "bebo" -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GRwGhnA8cP&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review
