[Bug 906765] Review Request: mingw-libwebp - MinGW compilation of Library and tools for the WebP format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=906765

--- Comment #4 from Kalev Lember <kalevlember@xxxxxxxxx> ---
Fedora review of mingw-libwebp-0.2.1-2.fc18.src.rpm 2013-03-25

+ OK
! needs attention

rpmlint output:

$ rpmlint mingw-libwebp-0.2.1-1.fc19.src.rpm \
          mingw32-libwebp-0.2.1-1.fc19.noarch.rpm \
          mingw64-libwebp-0.2.1-1.fc19.noarch.rpm \
          mingw32-libwebp-debuginfo-0.2.1-1.fc19.noarch.rpm \
          mingw64-libwebp-debuginfo-0.2.1-1.fc19.noarch.rpm
mingw-libwebp.src: W: spelling-error %description -l en_US WebP -> Web P, Web,
Webb
mingw-libwebp.src: W: spelling-error %description -l en_US lossy -> loss,
glossy, flossy
mingw-libwebp.src: W: spelling-error %description -l en_US codec -> codex,
code, codes
mingw-libwebp.src: W: invalid-url Source0:
http://webp.googlecode.com/files/libwebp-0.2.1.tar.gz HTTP Error 404: Not Found
mingw32-libwebp.noarch: W: spelling-error %description -l en_US WebP -> Web P,
Web, Webb
mingw32-libwebp.noarch: W: spelling-error %description -l en_US lossy -> loss,
glossy, flossy
mingw32-libwebp.noarch: W: spelling-error %description -l en_US codec -> codex,
code, codes
mingw64-libwebp.noarch: W: spelling-error %description -l en_US WebP -> Web P,
Web, Webb
mingw64-libwebp.noarch: W: spelling-error %description -l en_US lossy -> loss,
glossy, flossy
mingw64-libwebp.noarch: W: spelling-error %description -l en_US codec -> codex,
code, codes
mingw32-libwebp-debuginfo.noarch: E: debuginfo-without-sources
mingw64-libwebp-debuginfo.noarch: E: debuginfo-without-sources
5 packages and 0 specfiles checked; 2 errors, 10 warnings.

+ The rpmlint errors/warnings are harmless and can be ignored
+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
  native Fedora package
! No license file, even though it's shipped in the tarball (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  dc9b26f16bd5221414dbab95f13d4453  libwebp-0.2.1.tar.gz
  dc9b26f16bd5221414dbab95f13d4453  Download/libwebp-0.2.1.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Not applicable to MinGW packages.
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages must not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8


Add the COPYING file and it should be good to go.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ueV3975rkh&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]