Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923163 --- Comment #7 from Cosimo Cecchi <ccecchi@xxxxxxxxxx> --- (In reply to comment #5) > Here's the full review, very few is missing for the package to be approved. > :) Thanks Mathieu, I am a bit unclear on some points. > => The License tag should be: > License: GPLv2+ and LGPLv2+ and MIT and CC-BY and CC-BY-SA I always assumed the License: tag was about the overall license of the shipped binary, and not the individual licenses of source files inside the package. For example, GPLv2+, LGLPv2+ and MIT can be used together in a GPLv2-licensed binary (not sure the same applies to CC licenses though). I changed the spec file to your suggestion anyway. > [!]: Package contains no bundled libraries without FPC exception. > => Package bundles libgd, which is fine given the nature of libgd. > However: > - You should make that explicit, by adding: > Provides: bundled(libgd) > - libgd.so should not get installed, but be linked statically, as > explained by Matthias: > https://bugzilla.redhat.com/show_bug.cgi?id=919265#c6 I did the former; the latter is not possible for this package, since there's no C binary to statically link the library to. > => You **could** eventually make that a noarch subpackage. > > However, once you stop installing the bundled libgd, the only > arch-specific thing which remains in the package is the Gd-1.0.typelib > file, so having a noarch subpackage might be a bit overkill. > > Longterm, I believe libgd will eventually get merged into Gtk, right? > So at that point, the typelib won't get installed by gnome-weather any > more, and the whole package could be made noarch. > > With all the above in mind, I won't block the review on this, just try > to remember to make the whole package noarch when that becomes > possible. Yeah; right now I don't think it's useful to split any noarch part out of the package. Updated spec/SRPM for review at the same location. Spec URL: http://people.gnome.org/~cosimoc/gnome-weather/gnome-weather.spec SRPM URL: http://people.gnome.org/~cosimoc/gnome-weather/gnome-weather-3.7.92-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WXt0JXTJYq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review