Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911673 --- Comment #11 from Jeremy White <jwhite@xxxxxxxxxxxxxxx> --- > > A minor nit - the guidelines say 'MUST' run desktop-file-install; this .spec > > only does a desktop-file-validate. Not sure if this spec or the guidelines > > should change... > > Yeah, the wording in the guidelines is unclear. There's two distinct cases: > > 1) The package doesn't include the desktop file and we instead ship one in > the rpm package as a downstream change. In this case, like the guidelines > say, we MUST use the 'desktop-file-install' as opposed to just copying the > file to the final location. > > 2) The package includes a desktop file and installs it to the final > location itself. In that case, it doesn't make much sense to install it > again with 'desktop-file-install'; this is where 'desktop-file-validate' is > appropriate. > > Also, the guidelines say that it's either one or the other. Quoting: > "one MUST run desktop-file-install (in %install) OR desktop-file-validate > (in %check or %install)" To be complete: the detailed instructions: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#desktop are correct, but the summary page: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines is incomplete. But it is such a minor nit, and rather obvious, that I don't think any change is appropriate. Cheers, Jeremy -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7rNpgZZ5YH&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review