Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785460 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #7 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- ----- MUST: [!]: License field in the package spec file matches the actual license. Please correct License (with the comment) : # lib/Horde/Mime.php is BSD and LGPLv2 # other files are LGPLv2 License: LGPLv2 and BSD ----- SHOULD [!]: Requires correct, justified where necessary. A typo in the Requires list. BuildRequires: php-pear(PEAR) >= 1.7.0 Listed twice should be Requires: php-pear(PEAR) >= 1.7.0 ----- COULD [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required As Buildroot is not present, both could be clean (not a blocker) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nmfXuGPQmW&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review