Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xdg-user-dirs-gtk - gnome/gtk+ integration of xdg-user-dirs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230586 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-03-02 05:41 EST ------- GOOD - rpmlint checks do not return anything either on source or on binary package - package meets naming guidelines - package meets packaging guidelines - license ( GPL ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream, sha1sum 09ccb33dd147d969ec33a9e3d08daa1ca0c37202 xdg-user-dirs-gtk-0.1.tar.gz - package compiles on devel (x86_64) - no missing BR - MINOR: unnecessary BR: pkgconfig is pulled in by gtk2-devel - no locales, despite what the build log seems to say - not relocatable - owns all files/directories that it creates, does not take ownership of foreign files/directories - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - MUSTFIX the .desktop file does not contain all needed entries: /usr/bin/desktop-file-validate *desktop user-dirs-update-gtk.desktop: error: required key "Type" not found user-dirs-update-gtk.desktop: warning: non-standard key "OnlyShownIn" lacks the "X-" prefix According to http://fedoraproject.org/wiki/Packaging/Guidelines#desktop there are a few missing entries - MUSTFIX: still according to http://fedoraproject.org/wiki/Packaging/Guidelines#desktop, "It is not simply enough to just include the .desktop file in the package, one MUST run desktop-file-install in %install (and have BuildRequires: desktop-file-utils), to help ensure .desktop file safety and spec-compliance." - no .la, .pc, static content - devel not needed SHOULD - builds without problems in mock/devel/x86_64 - does not segfault at run. I am not a Gnome user, so I cannot really test if it creates what it supposed to create; a dry run in strace seems to appear OK Please fix the desktop issues (I suggest either a patch or going with the simpler version of a separate file included as Source1) and I will approve the package. You might also remove pkgconfig from BR if you wish since it's not really needed to be included separately. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review