Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=922165 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #6 from Michael Scherer <misc@xxxxxxxx> --- A few notes and questions : - Any reason to not use the systemd macros in %post ? - why does the %post of the api subpackage restart the compute service, and if that's not a error, why is there no requires from api to compute subpackages ? - "Patches link to upstream bugs/comments/lists or are otherwise justified.", there is 2 patch, so the fact they were sent upstream ( or not ) should be explained. especially the 2nd one, called "0002-add-LICENSE.patch", I am not sure that we can add license as we wish without having legal issues. - subpackage requires are wrong, since they need systemdctl and others for running the command. - /var/run/ceilometer must be in tmpfile.d ( https://fedoraproject.org/wiki/Packaging:Tmpfiles.d ) since /var/run is a tmpfs - why does it requires kombu and qpid ? Isn't it a runtime selection ? - %check is absent, but there is test, any reason to not run them ( or run only part of them ) ? - why is the documentation generation disabled by default ? - Requires(pre): shadow-utils this should be on common, since that's where the %post to create the user is located - the buildRequires in the doc subpackage are redundant with the main one, so they could be removed for most of them. - the license should be shipped with any combination of subpackages. For now, there is only a file in the api subpackage. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eSOj0MLaoV&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review