Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911607 Kalev Lember <kalevlember@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #4 from Kalev Lember <kalevlember@xxxxxxxxx> --- Fedora review gnome-mines-3.7.92-1.fc20.src.rpm 2013-03-23 + OK ! needs attention rpmlint output: $ rpmlint gnome-mines \ gnome-mines-debuginfo-3.7.92-1.fc19.x86_64.rpm \ gnome-mines-3.7.92-1.fc19.src.rpm gnome-mines.x86_64: W: obsolete-not-provided gnome-games-gnomine 3 packages and 0 specfiles checked; 0 errors, 1 warnings. + Rpmlint warning is harmless and can be ignored + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: e7895c445a231a661a8745b37144eb34 gnome-mines-3.7.92.tar.xz e7895c445a231a661a8745b37144eb34 Download/gnome-mines-3.7.92.tar.xz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane + The spec file handles locales properly n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base + Packages should not contain libtool .la files + Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 Issues ------ > Patch1: gnome-mines-desktop-keyword-po.patch Please submit the patch upstream. Or if you have already done so, please add the bugzilla ticket link to the spec file so I can prod the upstream people with a sharp stick, if needed. I've noted down some minor nitpicks down below, but they are far from being review blockers; just take a look and do what makes most sense to you: > BuildRequires: glib2-devel gtk3-devel Perhaps split this into two separate lines for consistency with the rest of the BRs? Could even sort the BRs to make it look even nicer! > %find_lang %{name} --all-name --with-gnome The --all-name switch isn't needed here, all of the translations / help files are installed under the 'gnome-mines' name. > %{_mandir}/man6/gnome-mines.6.gz The man page compression is done by rpm and might change in the future, would be safer to use a glob here: %{_mandir}/man6/gnome-mines.6* Also, might make sense to sort the files list. In any case, the spec file looks good and the nitpicks above are really minor. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hRmANgR3Ia&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review