Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fvwm - window manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223724 ------- Additional Comments From pertusus@xxxxxxx 2007-03-01 16:21 EST ------- rpmlint output is ignorable: W: fvwm devel-file-in-non-devel-package /usr/bin/fvwm-config I am not convinced that it is right to provide the perl provides since they are not in the perl module dir. It means filtering out all the provides, and from the requires: perl(FVWM::*) perl(FvwmCommand) perl(General::FileSystem) perl(General::Parse) Suggestions: add a trailing / to directories in %files to show visually that these are directories, like %{_datadir}/%{name}/ Give permission on install command line call, even if the result is righht by now: install -D -p -m755 %{SOURCE2} \ $RPM_BUILD_ROOT%{_bindir}/fvwm-xdg-menu -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review