Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915791 --- Comment #7 from Petr Šabata <psabata@xxxxxxxxxx> --- Ok, better now. Patches make sense, ok. Majority of the files don't mention their license, there's no license on the CPAN page and there's no LICENSE or COPYING file either. mogilefsd is 'GPLv2 or artistic' +who-knows and mogstored is '(GPLv2 or Artistic) and (GPL+ or Artistic)' +who-knows. Backends have no license at all. I'm not sure if we may assume Perl-like license or if this is okay or not. Asking upstream for clarification would help. Also, if it's possible to use a different License tag for each subpackage, do that for mogilefsd. You're missing a build-time dep, perl(MogileFS::Admin), required by various tests. Thanks to Patch0, perl(Fcntl) and perl(IO::AIO) are not required. You may drop those. And finally, what's the reason for that 'exit 0' in your scriptlets? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QV3sqaSpBB&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review