Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xdg-user-dirs - Handling of well known folders in homedir https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230585 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-03-01 14:03 EST ------- - rpmlint is silent both on source and binary rpm - package meets naming guidelines - package meets packaging guidelines - license (GPL ) is OK, matches source - spec file legible, in am. english - source matches upstream,is latest available version, sha1sum ddb6299faae1e23da524b113eb5d7a27c734630a xdg-user-dirs-0.3.tar.gz - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - locales properly handled via find_lang - not relocatable - owns all files/directories that it creates, does not take ownership of foreign files/directories - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - no scriptlets - no static, .la or .pc files SHOULD - package builds in mock/devel/x86_64 - works as advertised TODO - I suggest including the Changelog (including the one for translations) - I think that it would be a good idea to use "-p" when installing %Source1, in order to preserve the timestamp - MUSTFIX: include the license file, it exists in the tar.gz but is not included in %doc Package is APPROVED but please add the license before uploading to CVS -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review