Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #7 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Description OK. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. $ rpmlint ../SRPMS/nodejs-ronn-0.3.8-6.fc18.src.rpm ../RPMS/noarch/nodejs-ronn-0.3.8-6.fc18.noarch.rpm nodejs-ronn.src: W: spelling-error Summary(en_US) roff -> toff, riff, off nodejs-ronn.src: W: spelling-error Summary(en_US) html -> HTML, ht ml, ht-ml nodejs-ronn.src: W: spelling-error %description -l en_US Javascript -> JavaScript, Java script, Java-script nodejs-ronn.src: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-ronn.src: W: spelling-error %description -l en_US roff -> toff, riff, off nodejs-ronn.noarch: W: spelling-error Summary(en_US) roff -> toff, riff, off nodejs-ronn.noarch: W: spelling-error Summary(en_US) html -> HTML, ht ml, ht-ml nodejs-ronn.noarch: W: spelling-error %description -l en_US Javascript -> JavaScript, Java script, Java-script nodejs-ronn.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-ronn.noarch: W: spelling-error %description -l en_US roff -> toff, riff, off nodejs-ronn.noarch: W: only-non-binary-in-usr-lib nodejs-ronn.noarch: W: dangling-symlink /usr/lib/node_modules/ronn/node_modules/opts /usr/lib/node_modules/opts nodejs-ronn.noarch: W: dangling-symlink /usr/lib/node_modules/ronn/node_modules/markdown /usr/lib/node_modules/markdown nodejs-ronn.noarch: W: no-manual-page-for-binary ronn 2 packages and 0 specfiles checked; 0 errors, 14 warnings. TODO: Capitalize HTML in Summary. TODO: Capital S in JavaScript. Symlinks OK, requires npm(opts), npm(markdown) TODO: Work with upstream on a manpage All other duplicates or false positives. MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. Checked in LICENSE file, MIT. OK There is a BSDL part in the file, but the files are missing from this package, so it's not important. MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ sha256sum ../SOURCES/ronn-0.3.8.tgz 53a4837881bcd468ffdc8950272508a025c0bb9255d7460792412b8f820027e6 ../SOURCES/ronn-0.3.8.tgz $ spectool -g nodejs-ronn.spec $ sha256sum ronn-0.3.8.tgz 53a4837881bcd468ffdc8950272508a025c0bb9255d7460792412b8f820027e6 ronn-0.3.8.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, build in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/nodejs-ronn-0.3.8-6.fc18.noarch.rpm lrwxrwxrwx 1 root root 36 bře 21 15:15 /usr/bin/ronn -> ../lib/node_modules/ronn/bin/ronn.js drwxr-xr-x 2 root root 0 bře 21 15:15 /usr/lib/node_modules/ronn drwxr-xr-x 2 root root 0 bře 21 15:15 /usr/lib/node_modules/ronn/bin -rwxr-xr-x 1 root root 2940 lis 5 2011 /usr/lib/node_modules/ronn/bin/ronn.js drwxr-xr-x 2 root root 0 bře 21 15:15 /usr/lib/node_modules/ronn/lib -rw-r--r-- 1 root root 11986 bře 21 15:15 /usr/lib/node_modules/ronn/lib/ronn.js drwxr-xr-x 2 root root 0 bře 21 15:15 /usr/lib/node_modules/ronn/node_modules lrwxrwxrwx 1 root root 30 bře 21 15:15 /usr/lib/node_modules/ronn/node_modules/markdown -> /usr/lib/node_modules/markdown lrwxrwxrwx 1 root root 26 bře 21 15:15 /usr/lib/node_modules/ronn/node_modules/opts -> /usr/lib/node_modules/opts -rw-r--r-- 1 root root 696 bře 21 15:15 /usr/lib/node_modules/ronn/package.json drwxr-xr-x 2 root root 0 bře 21 15:15 /usr/share/doc/nodejs-ronn-0.3.8 -rw-r--r-- 1 root root 1720 lis 5 2011 /usr/share/doc/nodejs-ronn-0.3.8/CHANGES -rw-r--r-- 1 root root 2990 lis 5 2011 /usr/share/doc/nodejs-ronn-0.3.8/LICENSE -rw-r--r-- 1 root root 666 lis 5 2011 /usr/share/doc/nodejs-ronn-0.3.8/README.md -rw-r--r-- 1 root root 187 lis 5 2011 /usr/share/doc/nodejs-ronn-0.3.8/TODO MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK Package APPROVED. Consider fixing TODOs. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gRCLcXCJe9&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review