Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923564 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@xxxxxxxxx --- Comment #1 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Dan, welcome to fedora, some few comments about their spec: - Please put the flag FE-NEEDSPONSOR in the field "Blocks" I think this spec is based on this http://pkgs.fedoraproject.org/cgit/NetworkManager-openvpn.git/tree/NetworkManager-openvpn.spec but even this spec does not this exempt of some errors - the use of %define is deprecated, in their instead use %global See http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define - Epoch should only be used in Fedora as a last resort to resolve upgrade ordering of a package see http://fedoraproject.org/wiki/Packaging:Guidelines#Use_of_Epochs - We have new guidelines that covering how to handle sources from Github in a Fedora Package See http://fedoraproject.org/wiki/Packaging:SourceURL#Github - Check the versions available on fedora, I'm sure that we are in the higher versions than those defined here %define nm_version 1:0.9.2 %define dbus_version 1.1 %define gtk2_version 3.0.1 %define openssh_version 6.1 %define shared_mime_version 0.16-3 if so it will not be necessary to define - not needed define %{__install} rpm -E %{__install} /usr/bin/install in make install DESTDIR=%{buildroot} INSTALL="%{__install} -p" you can call "install" directly make DESTDIR=%{buildroot} INSTALL="install -p" CP="cp -p" install - I fail to see any files .desktop (installed or listed) in /usr/share/applications/, update-desktop-database is used when a desktop entry has a 'MimeType key. See http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database - this scriptlet must be used if the application install icons into one of the subdirectories in %{_datadir}/icons/ see http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache touch --no-create %{_datadir}/icons/hicolor if [ -x /usr/bin/gtk-update-icon-cache ]; then /usr/bin/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi - %defattr(-, root, root) is not needed - Why no there changelog entries ? - one question, this fork just taking whatever is in the current NetworkManager-openvpn tree or diverge? See https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries Cheers - Eduardo -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e0FYEnJKR5&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review