Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=922165 Kashyap Chamarthy <kchamart@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kchamart@xxxxxxxxxx --- Comment #1 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- Initial review from fedora-review tool. Manaul investigation needs to be done. >From an initial glance, there appears to be some install errors. That was the command I invoked: ----------- $ fedora-review -m fedora-rawhide-x86_64 --rpm-spec -n openstack-ceilometer-2013.1-0.1.g3.fc18.src.rpm ----------- Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- ceilometer , openstack-ceilometer-common , openstack-ceilometer-compute , openstack-ceilometer-central , openstack-ceilometer-collector , openstack-ceilometer-api [ ]: Package complies to the Packaging Guidelines [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 3 files have unknown license. Detailed output of licensecheck in /home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 3 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Installation errors ------------------- INFO: mock.py version 1.1.29 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Mock Version: 1.1.29 INFO: Mock Version: 1.1.29 Start: lock buildroot INFO: installing package(s): /home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/results/python-ceilometer-2013.1-0.1.g3.fc19.noarch.rpm /home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/results/openstack-ceilometer-common-2013.1-0.1.g3.fc19.noarch.rpm /home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/results/openstack-ceilometer-compute-2013.1-0.1.g3.fc19.noarch.rpm /home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/results/openstack-ceilometer-central-2013.1-0.1.g3.fc19.noarch.rpm /home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/results/openstack-ceilometer-collector-2013.1-0.1.g3.fc19.noarch.rpm /home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/results/openstack-ceilometer-api-2013.1-0.1.g3.fc19.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-x86_64/root/', 'install', '/home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/results/python-ceilometer-2013.1-0.1.g3.fc19.noarch.rpm', '/home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/results/openstack-ceilometer-common-2013.1-0.1.g3.fc19.noarch.rpm', '/home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/results/openstack-ceilometer-compute-2013.1-0.1.g3.fc19.noarch.rpm', '/home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/results/openstack-ceilometer-central-2013.1-0.1.g3.fc19.noarch.rpm', '/home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/results/openstack-ceilometer-collector-2013.1-0.1.g3.fc19.noarch.rpm', '/home/kashyap/rpmbuild/SRPMS/openstack-ceilometer/results/openstack-ceilometer-api-2013.1-0.1.g3.fc19.noarch.rpm', '--setopt=tsflags=nocontexts'] Error: Package: openstack-ceilometer-api-2013.1-0.1.g3.fc19.noarch (/openstack-ceilometer-api-2013.1-0.1.g3.fc19.noarch) Requires: python-wsme You could try using --skip-broken to work around the problem Error: Package: python-ceilometer-2013.1-0.1.g3.fc19.noarch (/python-ceilometer-2013.1-0.1.g3.fc19.noarch) Requires: python-stevedore You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: python-ceilometer-2013.1-0.1.g3.fc19.noarch.rpm openstack-ceilometer-common-2013.1-0.1.g3.fc19.noarch.rpm openstack-ceilometer-compute-2013.1-0.1.g3.fc19.noarch.rpm openstack-ceilometer-central-2013.1-0.1.g3.fc19.noarch.rpm openstack-ceilometer-collector-2013.1-0.1.g3.fc19.noarch.rpm openstack-ceilometer-api-2013.1-0.1.g3.fc19.noarch.rpm python-ceilometer.noarch: E: explicit-lib-dependency python-amqplib python-ceilometer.noarch: W: no-documentation openstack-ceilometer-common.noarch: W: non-standard-gid /etc/ceilometer/ceilometer.conf ceilometer openstack-ceilometer-common.noarch: E: non-readable /etc/ceilometer/ceilometer.conf 0640L openstack-ceilometer-common.noarch: W: non-standard-gid /etc/ceilometer/policy.json ceilometer openstack-ceilometer-common.noarch: E: non-readable /etc/ceilometer/policy.json 0640L openstack-ceilometer-common.noarch: E: incoherent-logrotate-file /etc/logrotate.d/openstack-ceilometer openstack-ceilometer-common.noarch: W: non-standard-uid /var/log/ceilometer ceilometer openstack-ceilometer-common.noarch: W: non-standard-gid /etc/ceilometer/sources.json ceilometer openstack-ceilometer-common.noarch: E: non-readable /etc/ceilometer/sources.json 0640L openstack-ceilometer-common.noarch: W: non-standard-uid /var/run/ceilometer ceilometer openstack-ceilometer-common.noarch: W: non-standard-uid /var/lib/ceilometer ceilometer openstack-ceilometer-common.noarch: W: non-standard-gid /var/lib/ceilometer ceilometer openstack-ceilometer-common.noarch: W: non-standard-uid /var/lib/ceilometer/tmp ceilometer openstack-ceilometer-common.noarch: W: non-standard-gid /var/lib/ceilometer/tmp ceilometer openstack-ceilometer-common.noarch: W: no-manual-page-for-binary ceilometer-dbsync openstack-ceilometer-common.noarch: W: no-manual-page-for-binary ceilometer-agent-compute openstack-ceilometer-common.noarch: W: no-manual-page-for-binary ceilometer-api openstack-ceilometer-common.noarch: W: no-manual-page-for-binary ceilometer-agent-central openstack-ceilometer-common.noarch: W: no-manual-page-for-binary ceilometer-collector openstack-ceilometer-compute.noarch: W: only-non-binary-in-usr-lib openstack-ceilometer-compute.noarch: W: no-documentation openstack-ceilometer-compute.noarch: W: no-manual-page-for-binary ceilometer-agent-compute openstack-ceilometer-central.noarch: W: only-non-binary-in-usr-lib openstack-ceilometer-central.noarch: W: no-documentation openstack-ceilometer-central.noarch: W: no-manual-page-for-binary ceilometer-agent-central openstack-ceilometer-collector.noarch: W: only-non-binary-in-usr-lib openstack-ceilometer-collector.noarch: W: no-documentation openstack-ceilometer-collector.noarch: W: no-manual-page-for-binary ceilometer-collector openstack-ceilometer-api.noarch: W: only-non-binary-in-usr-lib openstack-ceilometer-api.noarch: W: no-manual-page-for-binary ceilometer-api 6 packages and 0 specfiles checked; 5 errors, 26 warnings. Requires -------- openstack-ceilometer-central (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python openstack-ceilometer-common python-glanceclient python-keystoneclient python-novaclient python-swiftclient openstack-ceilometer-compute (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python libvirt-python openstack-ceilometer-common python-keystoneclient python-novaclient openstack-ceilometer-api (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python openstack-ceilometer-common pymongo python-flask python-pecan python-wsme openstack-ceilometer-collector (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python openstack-ceilometer-common pymongo python-ceilometer (rpmlib, GLIBC filtered): python(abi) python-amqplib python-anyjson python-eventlet python-greenlet python-iso8601 python-kombu python-lxml python-migrate python-qpid python-sqlalchemy python-stevedore python-webob openstack-ceilometer-common (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python config(openstack-ceilometer-common) python-ceilometer Provides -------- openstack-ceilometer-central: openstack-ceilometer-central openstack-ceilometer-compute: openstack-ceilometer-compute openstack-ceilometer-api: openstack-ceilometer-api openstack-ceilometer-collector: openstack-ceilometer-collector python-ceilometer: python-ceilometer openstack-ceilometer-common: config(openstack-ceilometer-common) openstack-ceilometer-common MD5-sum check ------------- http://tarballs.openstack.org/ceilometer/ceilometer-2013.1.g3.tar.gz : CHECKSUM(SHA256) this package : a12aec52f262d909e6d3164728b94faf6d8c55fa7aa191ad68e540c90da90692 CHECKSUM(SHA256) upstream package : a12aec52f262d909e6d3164728b94faf6d8c55fa7aa191ad68e540c90da90692 Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 --rpm-spec -n openstack-ceilometer-2013.1-0.1.g3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t5rIgWX8mC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review