Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=794793 --- Comment #4 from Dan Horák <dan@xxxxxxxx> --- first notes: - Release must start with 1 for released projects, %{?dist} is missing - see https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag - use an acronym for License, see https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses for license list, also the licensing is unclear in the source code, simple inclusion of OpenSSL license in the LICENSE file is not sufficient, best option is to include licensing header in all source files or at least a notice in README (any file created by the authors), also read https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ - Group is wrong, see /usr/share/doc/rpm-*/GROUPS for a list, or omit Group compeltely - you can drop BuildRoot, %defattr and whole %clean because rpm will take care of it itself - there should be no need export CFLAGS/CPPFLAGS, teh %configure macro already does it - use -q in %setup, drop -n, the %{name}-%{version} format is used by default - I'd drop the license header on top of the spec completely (if possible), see https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#License_of_Fedora_SPEC_Files For more information about packaging rules in Fedora please see https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines and if you have any questions please ask. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dfarCIVKqM&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review