[Bug 907261] Review Request: poly2tri - A 2D constrained Delaunay triangulation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=907261

--- Comment #13 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> ---
(In reply to comment #12)
> (In reply to comment #11)
> > Why are you creating your own Makefile?  Upstream appears to use the WAF
> > build system.
> 
> The waf build system builds example apps for the library. The library is
> included in the apps and is not built as an dynamic one.

You might want to add a comment to that effect to the spec file then.

> > (In reply to comment #10)
> > What's upstreams ABI story?  Generally you only want x.y.z SONAMEs if you're
> > changing the ABI every x.y.z release?  If they're not bumping ABI until 2.0
> > a soname of simply 1 would be appropriate.
> > 
> > Also, the SONAME embedded in the library is 0:
> > $ readelf -a
> > BUILDROOT/poly2tri-0.0-3.20120407hgacf81f1f1764.fc18.x86_64/usr/lib64/
> > libpoly2tri.so.1.0.0 | grep SONAME
> >  0x000000000000000e (SONAME)             Library soname: [libpoly2tri.so.0]
> Will look at that. Thanks

Since you apparently do need your own Makefile, fixing this is as simple as
passing "-Wl,-soname,libpoly2tri.so.1.0.0" (assuming you stick with 1.0.0 as
the soname) to gcc when you build the library.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8s0Mrwi5gH&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]