Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #10 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- (In reply to comment #9) > > $ ldd build/test/fis > > linux-vdso.so.1 => (0x00007fff907fe000) > > libGKlib.so.5.0.3 => > > /home/pcpa/rpmbuild/BUILD/metis-5.0.3/GKlib/build/libGKlib.so.5.0.3 > > (0x00007f85e6521000) > > libm.so.6 => /lib64/libm.so.6 (0x00000035e3400000) > > libc.so.6 => /lib64/libc.so.6 (0x00000035e3000000) > > /lib64/ld-linux-x86-64.so.2 (0x00000035e2c00000) > > These binaries seem be used exclusively by upstream (as developer confirmed > to me); also they could lead to false positives in future. This comes back to my comment in #4: ---%<--- First, I have a feeling GKlib is not supposed to be installed, well, the .c files are compiled and added to libmetis.so, so anything linking to libmetis and libGKlib will fail due to duplicated symbols. And upstream may not want the header files installed to not have a compromise with an API/ABI. ---%<--- > Maybe we can ignore them. :) Can you confirm the GKlib headers are not supposed to be installed? Note that this still does not mean running the test binaries in %check is not required :-) They are supposed to work in the build environment, and would make it easier to validate that the package works as intended. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mtTZ43MLj5&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review