Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=922291 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- No real blocker, but please just answer a few questions before I approve this package I will prefer you don't remove PropertyAccessorCustomArrayObjectTest.php test script but rather remove it only in %check Can't you use the upstream "autoloader.php" instead of building your ? (well, it seems preferable to rely on include_path instead on this stupid file_exists) Why do you edit the phpunit.xml.dist and not simply create a phpunit.xml and add it to the package ? Are .git* files, and role issue reported upstream ? (please add a link to upstream bug) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9bNqELKFSD&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review