[Bug 919867] Review Request: billiards - A free cue sports simulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=919867

--- Comment #3 from Tadej Janež <tadej.janez@xxxxxxxxxxxxxxxxx> ---
Hans, thank you for reviewing the package!

(In reply to comment #2)
> Needs work:
> - rpmlint checks return:
>  billiards.x86_64: E: no-binary
>  billiards-debuginfo.x86_64: E: empty-debuginfo-package
> This is caused by billiards being written completely in lua, this is fine,
> but the package should be noarch then. Adding: "BuildArch: noarch" to the
> specfile fixes this.

The author of Billiards said to me that there is a problem with packaging
Billiards as an arch-independent package since it contains byte-compiled Lua
files (the .lc files) which are arch-dependent.

I've filled a bug report about rpmlint not recognizing Lua byte-files, which
has just recently been fixed upstream:
https://sourceforge.net/p/rpmlint/code/ci/be327c1b08402115aa050a6d8160bd2d05d5efd2/

Although this brings a new problem
(https://bugzilla.redhat.com/show_bug.cgi?id=919869#c1):
"...you cannot ship the *.lc files in /usr/share, they need to be somewhere in
/usr/lib(64) instead."
I don't know what is the best way to solve this?

Also, I've disabled the generation of the empty debuginfo package and added a
comment explaining that.

> -%makeinstall should not be used except for broken Makefiles, Use "make
> install DESTDIR=%{buildroot}" instead.

I think you misread the .spec file. I used %make_install, which has been
approved by the Packaging guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
(last line of the section).

> -The info file being gzipped is done by rpmbuild and this may change to
> another compression format in the future. You should drop the .gz from the
> scriptlets (install-info will figure it out itself) and the %files entry
> should be:
> %{_infodir}/%{name}.info*

Thanks for pointing this out. Fixed.

New spec and SRPM files are here:
http://tadej.fedorapeople.org/billiards.spec
http://tadej.fedorapeople.org/billiards-0.4.1-2.fc17.src.rpm

Regards,
Tadej

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HFsYWqFiBz&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]