Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919429 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Hans de Goede <hdegoede@xxxxxxxxxx> --- (In reply to comment #3) > New files: > Spec URL: http://dbp.zom.dk/gimp-dbp.spec > SRPM URL: http://dbp.zom.dk/gimp-dbp-1.1.9-2.fc18.src.rpm Looks good now, approved! One minor nitpick, in the ChangeLog you write: - Include screenshots - Include translation file This may lead people to think that they are included in the binary packages, which they are not, the only thing which changed is that they are no longer being removed from the builddir in %prep. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dVoHFcZJRy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review