Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915337 --- Comment #7 from Palle Ravn <ravnzon@xxxxxxxxx> --- (In reply to comment #6) > Full review done: > > Good: > - ... > - package meets naming guidelines (but not versioning, see below) I'm looking below and I don't see more about the versioning, can you clarify this for me? > Needs work: > -The Source0 and Source1 urls are wrong, we've a preferred down url form for > sf.net, see: Now following the guidelines. > http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net > -The generated manpage is rubish, it contains the same bit twice, and then a > reference to the non-existent texinfo documentation. Luckily Debian has > already packaged nmon and provides a manpage for us :) See: > ftp://ftp.nluug.nl/pub/os/Linux/distr/debian/pool/main/n/nmon/ > nmon_13g+debian-1.debian.tar.gz The Debian manpage has also been committed on sourceforge under patches, so I downloaded that one. However, I'm not able to follow the sourceforge guidelines for this link. There's a second manpage, which covers more of the documentation, and I would like to use that one, but I has some unwanted references to a screenshot list in its intro. I'm considering rewriting it a bit and then use it, what are your thoughts on that? link: http://sourceforge.net/tracker/?func=detail&aid=3295760&group_id=271307&atid=1153693 > -Drop the now no longer needed "BuildRequires: help2man" Now using install -D -p -m 0655 for the nmon.1 manpage. > ... you > *MUST* mail upstream asking them to do better for their next release. While > mailing upstream, please attach the Debian manpage and ask them to add that > to the tarbal too. I have mailed Nigel using sourceforges mailing system, as I'm unable to find any other contact information, and asked for inclusion of license file and header, manpage, and tarball releases. The projects mailing list has a total of 2 messages, from the same person as he never received an answer, I'm guessing nobody reads it. I could make feature requests for the above, but I'm not a fan of that, as it has nothing to do with the functionality of the program. > -manpages should not be marked %doc Removed %doc. New files Spec URL: http://nmon.zom.dk/nmon.spec SRPM URL: http://nmon.zom.dk/nmon-14g-3.fc18.src.rpm rpmlint: nmon.x86_64: W: unstripped-binary-or-object /usr/bin/nmon 2 packages and 1 specfiles checked; 0 errors, 1 warnings. koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5135115 PowerPC http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=998047 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8QYBpKvHko&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review