Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #8 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- (In reply to comment #7) > Spec URL: http://sagitter.fedorapeople.org/metis/metis.spec > SRPM URL: http://sagitter.fedorapeople.org/metis/metis-5.0.3-4.fc18.src.rpm > > >-------------------------------------------------- > >5. You should not need to install the graphs subdir to > > %{_datadir}/%{name}/graphs, but instead, use them, as > > they are actually example input files, in a %check > > section. Also, should add GKlib/test binaries to a > > %check run. > > Onestly I don't see any GKlib/test binaries. :) If you run make in the GKlib directory it creates test binaries: $ pwd /home/pcpa/rpmbuild/BUILD/metis-5.0.3/GKlib $ ls test/*.c test/fis.c test/gkgraph.c test/gksort.c test/rw.c test/strings.c $ ls build/test CMakeFiles cmake_install.cmake fis gkgraph gksort Makefile rw strings $ ldd build/test/fis linux-vdso.so.1 => (0x00007fff907fe000) libGKlib.so.5.0.3 => /home/pcpa/rpmbuild/BUILD/metis-5.0.3/GKlib/build/libGKlib.so.5.0.3 (0x00007f85e6521000) libm.so.6 => /lib64/libm.so.6 (0x00000035e3400000) libc.so.6 => /lib64/libc.so.6 (0x00000035e3000000) /lib64/ld-linux-x86-64.so.2 (0x00000035e2c00000) > >12. Binaries are being installed with 775 permission. Check > >it, should be 755. > > They seem me all with 755: > > $ ll /usr/bin | grep metis > -rwxr-xr-x. 1 root root 43024 Mar 17 19:55 gpmetis > -rwxr-xr-x. 1 root root 31040 Mar 17 19:55 m2gmetis > -rwxr-xr-x. 1 root root 43152 Mar 17 19:55 mpmetis > -rwxr-xr-x. 1 root root 40624 Mar 17 19:55 ndmetis Try running fedora-review, tail of review.txt: Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -r -v -n metis and review.txt says: Rpmlint (installed packages) ---------------------------- # rpmlint metis metis-devel metis.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti metis.x86_64: E: non-standard-executable-perm /usr/bin/cmpfillin 0775L metis.x86_64: E: non-standard-executable-perm /usr/bin/mpmetis 0775L metis.x86_64: E: non-standard-executable-perm /usr/lib64/metis/libmetis.so 0775L metis.x86_64: E: non-standard-executable-perm /usr/bin/m2gmetis 0775L metis.x86_64: E: non-standard-executable-perm /usr/bin/ndmetis 0775L metis.x86_64: E: non-standard-executable-perm /usr/bin/graphchk 0775L metis.x86_64: E: non-standard-executable-perm /usr/bin/gpmetis 0775L metis.x86_64: W: no-manual-page-for-binary cmpfillin metis.x86_64: W: no-manual-page-for-binary gpmetis metis.x86_64: W: no-manual-page-for-binary graphchk metis.x86_64: W: no-manual-page-for-binary mpmetis metis.x86_64: W: no-manual-page-for-binary ndmetis metis.x86_64: W: no-manual-page-for-binary m2gmetis 2 packages and 0 specfiles checked; 7 errors, 7 warnings. # echo 'rpmlint-done:' If I recall correctly, fedora-review (or mock?) on purpose use a non standard umask to trigger cases of builds relying on a default umask. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7DF3458Srp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review