Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910137 --- Comment #3 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> --- Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-node-stringprep.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-node-stringprep-0.1.5-3.fc18.src.rpm > Node guidelines say that where the compiled module is the main entry > point it should be called %{nodejs_sitelib}/<module name>/<module_name>.node Fixed. > The explicit requires on v8 should not be needed any more. Removed. > There is no debuginfo package for some reason. It's present now. > The second patch can be offered upstream - although older versions > of node work without an explicit NODE_MODULE they still accept it > as I understand things. Pull request sent. > Tests spit out a string of warnings: Fixed. > nodejs-node-stringprep.x86_64: E: non-standard-executable-perm /usr/lib/node_modules/node-stringprep/build/node_stringprep.node 0775L Fixed. > The comment about not be able to make index.node work is not > relevant as the packaging guidelines say to use module_name.node > in this case anyway. Removed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zPyvZxukau&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review