Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906481 --- Comment #3 from Jos de Kloe <josdekloe@xxxxxxxxx> --- Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Note: Documentation size is 4300800 bytes in 211 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - end-of-line issue: see after the rpmlint output below - timestamps are not preserved in install step, see comment below Please address these points in your next version. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. ==>needs work, i.e. add '-p' option to install step [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4474880 bytes in /usr/share 4474880 erlang-cowboy-0.8.2-1.fc19.x86_64.rpm ==>I tend to agree here. The amount and size of the doc files clearly is way larger than the module itself, so a separate no-arch doc package should be used here. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: erlang-cowboy-0.8.2-1.fc19.x86_64.rpm erlang-cowboy.x86_64: E: no-binary erlang-cowboy.x86_64: W: only-non-binary-in-usr-lib erlang-cowboy.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/erlang-cowboy-0.8.2/examples/websocket/priv/static/jquery.min.js 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint erlang-cowboy erlang-cowboy.x86_64: E: no-binary erlang-cowboy.x86_64: W: only-non-binary-in-usr-lib erlang-cowboy.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/erlang-cowboy-0.8.2/examples/websocket/priv/static/jquery.min.js 1 packages and 0 specfiles checked; 1 errors, 2 warnings. # echo 'rpmlint-done:' ==>a solution using sed to the end-of-line issue is mentioned here: https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding Requires -------- erlang-cowboy (rpmlib, GLIBC filtered): /bin/sh erlang-crypto(x86-64) erlang-erts(x86-64) erlang-kernel(x86-64) erlang-ranch(x86-64) erlang-stdlib(x86-64) Provides -------- erlang-cowboy: erlang-cowboy erlang-cowboy(x86-64) Built with local dependencies: /home/user_to_make_rpms/reviews/906481.erlang-cowboy/../906473-erlang-ranch/906473-erlang-ranch/results/erlang-ranch-0.6.1-2.fc19.x86_64.rpm /home/user_to_make_rpms/reviews/906481.erlang-cowboy/../906473-erlang-ranch/906473-erlang-ranch/results/erlang-ranch-0.6.1-2.fc19.src.rpm Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/bin/fedora-review -b 906481 -m fedora-rawhide-x86_64 -L ../906473-erlang-ranch/906473-erlang-ranch/results -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z3DYXLMKa3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review