Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915337 --- Comment #6 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Hi, Full review done: Good: - rpmlint checks return: 3 packages and 1 specfiles checked; 0 errors, 0 warnings. - package meets naming guidelines (but not versioning, see below) - package meets packaging guidelines - license (GPLv3) OK, but text not in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Needs work: -The Source0 and Source1 urls are wrong, we've a preferred down url form for sf.net, see: http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net -The generated manpage is rubish, it contains the same bit twice, and then a reference to the non-existent texinfo documentation. Luckily Debian has already packaged nmon and provides a manpage for us :) See: ftp://ftp.nluug.nl/pub/os/Linux/distr/debian/pool/main/n/nmon/nmon_13g+debian-1.debian.tar.gz -Drop the now no longer needed "BuildRequires: help2man" -The lmon14g.c file does not contain a clear copyright-header, and upstream does not provide a copy of the GPLv3 (typically upstream provides a COPYING.txt), this is not a blocker, but please mail upstream asking them to do a new release with a proper copyright-header, and while they are at it they should add a COPYING.txt with the GPLv3 and put all the files together in a tarbal. As said this is not a blocker for getting this package into Fedora, but you *MUST* mail upstream asking them to do better for their next release. While mailing upstream, please attach the Debian manpage and ask them to add that to the tarbal too. -manpages should not be marked %doc Regards, Hans -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ghpQHQvT9f&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review