Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #6 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- (In reply to comment #5) > (In reply to comment #4) > > > > > > 7. My suggestion to invoke cmake directly was due > > to no other way to set some options, but you should > > follow the pattern in the toplevel Makefile, that has: > > ---%<--- > > CONFIG_FLAGS = -DCMAKE_VERBOSE_MAKEFILE=1 > > ifeq ($(gklib_path), not-set) > > gklib_path = GKlib > > endif [...] > > ---%<--- > > Actually, it may be better to add a libsuffix extra > > option to the Makefile instead of invoking cmake. > > > > I don't understand what you mean here. It was a suggestion to add one (or more) extra option(s) appended to CONFIG_FLAGS, because the toplevel Makefile calls cmake aready, in this chunk: mkdir -p $(BUILDDIR) cd $(BUILDDIR) && cmake $(CURDIR) $(CONFIG_FLAGS) Untested patch to add to the toplevel Makefile would be: libsuffix = not-set [...] ifneq ($(cc), not-set) CONFIG_FLAGS += -DCMAKE_C_COMPILER=$(cc) endif ifneq ($(libsuffix), not-set) CONFIG_FLAGS += -DLIB_SUFFIX=$(libsuffix) endif and then invoke the toplevel Makefile with the extra option: make ... libsuffix=64 if on a 64 bit arch. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CW99q6EQaZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review