Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907261 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tchollingsworth@xxxxxxxxx Flags| |fedora-review? --- Comment #11 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- Why are you creating your own Makefile? Upstream appears to use the WAF build system. (In reply to comment #10) > Using soname version 1.0.0 > See http://code.google.com/p/poly2tri/issues/detail?id=66#c1 for > justification What's upstreams ABI story? Generally you only want x.y.z SONAMEs if you're changing the ABI every x.y.z release? If they're not bumping ABI until 2.0 a soname of simply 1 would be appropriate. Also, the SONAME embedded in the library is 0: $ readelf -a BUILDROOT/poly2tri-0.0-3.20120407hgacf81f1f1764.fc18.x86_64/usr/lib64/libpoly2tri.so.1.0.0 | grep SONAME 0x000000000000000e (SONAME) Library soname: [libpoly2tri.so.0] -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2Mj5JwpLwd&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review