Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=806117 --- Comment #13 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Abdel == TODO == - Don't need do the duplicate declaration of %doc, easily you can include the files in one only declaration, please fix - Please add the boiler plate of the license in %Source1, upstream explain explicitely in the LICENSE file that the package is ASL2.0 and invite to obtain a copy, the copy should be obtained from http://www.apache.org/licenses/LICENSE-2.0.txt - tests should be run at some point, when the package is approved ,please seek work soon with upstream for provide tests that work well in python3 and python2, also provide the opportunity to build the package correctly on both stacks, Remember that we are not allowed to build python3 packages if upstream does not give full support (and in this case, upstream not given this support) - From what I see, you plan to ship this package to epel5 therefore need to follow appropriate guidelines, see http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL5, i.e. buildroot present, clean of the buildroot,and %defattr, but there are a problem, the build fails on epel5.If you ask me, I am among those who believe that we should gradually be left support to el5, and moving on to el6 directly. Why? make things easier for packager and el6 also shares the same Fedora packaging guidelines - I copy and paste the el5 build error here: + /usr/bin/unzip -qq /builddir/build/SOURCES/Oplop-1.6.zip + STATUS=0 + '[' 0 -ne 0 ']' + cd Oplop-1.6 ++ /usr/bin/id -u + '[' 1001 = 0 ']' ++ /usr/bin/id -u + '[' 1001 = 0 ']' + /bin/chmod -Rf a+rX,u+w,g-w,o-w . + exit 0 Ejecutando(%build): /bin/sh -e /var/tmp/rpm-tmp.45353 + umask 022 + cd /builddir/build/BUILD + cd Oplop-1.6 + LANG=C + export LANG + unset DISPLAY + /usr/bin/python setup.py build File "setup.py", line 15 with open('README', 'r') as file: ^ SyntaxError: invalid syntax ==================================================================== afaik, the python binary on el5 is Python 2.4, "with statement" was introduced in python 2.5, (understand because I say it is easier to move on to epel 6?) == EPEL6 == the package build fails too, due to small error: * File not found: /builddir/build/BUILDROOT/python-oplop-1.6-3.el6.x86_64/usr/lib/python2.6/site-packages/Oplop-1.6-py2.7.egg-info in the spec you have this line: %{python_sitelib}/%{zip_name}-%{version}-py2.7.egg-info this line should be %{python_sitelib}/%{zip_name}-%{version}-*.egg-info Regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=APBGh3ausa&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review