Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875308 --- Comment #8 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- 1) Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires Simply add BR python2-devel to solve this. 2) update-desktop-database is invoked when required Note: desktop file(s) in mate-menu-editor See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache No need to update mime-database, mozo doesn't install any XML file in %{_datadir}/mime/packages http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo Change rpm scriptlets to: %post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi 3) We don't need to add '--add-category="X-Mate"'in desktop files since MATE is registered for 'OnlyShowIn' in desktop-file-utils package > 0.19. see https://bugs.freedesktop.org/show_bug.cgi?id=52493 https://bugs.freedesktop.org/show_bug.cgi?id=44353 This affected all Mate packages! Removing category 'Mate' is already done in upstream and include in latest version. https://github.com/mate-desktop/mate-menu-editor/commit/7a60493ade21bbd92ea6af2b1b1ffba2c0942fcf Pls remove desktop-file-install part and add %check desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/mozo.desktop 4) Pls own directories and change to %{_datadir}/mozo/ %{python_sitelib}/Mozo/ I'm not really shure in this point if mozo wouldn't taken ownwership of %{_datadir} and %{python_sitelib} too. I will ask Rex. The rest looks good except rpmlint incorrect-fsf-address error, which we can ignore here in fedora. Pls upload new SPECS and SRPMS links for final review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=I7jI2GdRZ3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review