Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #11 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> --- Ok, the package looks very good now! :) If I could, I would approve your package, provided that the legal team confirms I didn't make any mistake with that License tag. I wrote to the legal team to have a quick confirmation: http://lists.fedoraproject.org/pipermail/legal/2013-March/002109.html Remaining issues: ================ [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. => The license tag appears correct to me, but it is more complex than what I've been used to, so I'd appreciate a confirmation from the legal team. Details: ======== --- bijiben.spec.bak 2013-03-15 12:57:11.441577743 +0800 +++ bijiben.spec 2013-03-15 15:54:42.000000000 +0800 @@ -1,36 +1,37 @@ Name: bijiben Version: 3.7.91 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Simple Note Viewer -# Bijiben is GPLv3+ appart a few files "LGPLv2 or LGPLv3" +# Bijiben is GPLv3+ apart a few files "LGPLv2 or LGPLv3" # And ligd is LGPLv2+ License: GPLv3+ and LGPLv3 and LGPLv2+ Url: http://www.gnome.org Source0: http://ftp.gnome.org/pub/GNOME/sources/%{name}/3.7/%{name}-%{version}.tar.xz # Do not use GPLv2+, but GPLv3+ -# Done upstream +# Done upstream : commit 45e77b6fbdd46873ef9de7e1b8caf41a22a2c6d0 Patch0: license-use-consistently-GPLv3.patch # Do not have libgd.so -# Done upstream +# Done upstream : commit 9f6bd4e1101a43e9a25133e74500b462bc361f5e Patch1: static-libgd.patch -BuildRequires: intltool +BuildRequires: clutter-gtk-devel >= 1.4.2 +BuildRequires: desktop-file-utils => Fixes validation of the desktop file +BuildRequires: intltool BuildRequires: itstool BuildRequires: gettext BuildRequires: glib2-devel >= 2.28.0 BuildRequires: gtk3-devel >= 3.5.19 -BuildRequires: tracker-devel => 0.15.2 -BuildRequires: clutter-gtk-devel >= 1.4.2 +BuildRequires: libuuid-devel BuildRequires: libxml2-devel BuildRequires: libzeitgeist-devel >= 0.3.18 +BuildRequires: tracker-devel => 0.15.2 BuildRequires: webkitgtk3-devel >= 1.11.91 -BuildRequires: libuuid-devel BuildRequires: yelp-tools + # libgd is not meant to be installed as a system-wide shared library. # It is just a way for GNOME applications to share widgets and other common # code on an ad-hoc basis. @@ -66,6 +67,7 @@ %post /usr/bin/update-desktop-database &> /dev/null || : +/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : => Fixes handling of installed icons. %postun /usr/bin/update-desktop-database &> /dev/null || : @@ -99,6 +101,10 @@ %exclude %{_libdir}/%{name}/libgd.la %changelog +* Fri Mar 15 2013 Pierre-Yves Luyten <py@xxxxxxxxx> - 3.7.91-3 +- Fix icon update (timestamp) in post +- BuildRequire desktop-file-utils + * Wed Mar 13 2013 Pierre-Yves Luyten <py@xxxxxxxxx> - 3.7.91-2 - Patch to get rid of GPLv2+ - Patch to use static link to libgd -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=72u4nSGUbV&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review