Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920387 --- Comment #3 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- ===== Manual review of MUST items from Comment #1 ===== [X ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. - Apache License Version 2.0 [X]: Changelog in prescribed format. [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: Package contains no bundled libraries without FPC exception. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [X]: Package uses nothing in %doc for runtime. [X]: Package is not known to require ExcludeArch. [X]: Package complies to the Packaging Guidelines [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* Apache (v2.0)". 2 files have unknown license. Detailed output of licensecheck in /home/kashyap/rpmbuild/SRPMS /heat-cfntools/licensecheck.txt -> Output from licensecheck.txt ================================ $ cat licensecheck.txt Apache (v2.0) ------------- /var/lib/mock/fedora-18-x86_64/root/builddir/build/BUILD/heat-cfntools-1.2/heat_cfntools/tests/test_cfn_helper.py *No copyright* Apache (v2.0) ---------------------------- /var/lib/mock/fedora-18-x86_64/root/builddir/build/BUILD/heat-cfntools-1.2/setup.py ================================ [X]: Package consistently uses macro is (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Package must own all directories that it creates. [X]: Package does not own files or directories owned by other packages. [X ]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: The only minor nit is there's no copyright in -- /var/lib/mock/fedora-18-x86_64/root/builddir/build/BUILD/heat-cfntools-1.2/setup.py As it's under a MUST item, it needs to be addressed I guess. Rest all looks good to me, package approved w/ the above nit addressed. Scratch build successful per comment #2. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xhdYe9mle7&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review