Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919948 Jon VanAlten <jon.vanalten@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #6 from Jon VanAlten <jon.vanalten@xxxxxxxxxx> --- (In reply to comment #3) > > What I'm a little worried about is the invalid-url warnings. See also below. > > Sorry about that. Most of these tarballs are generated. I have added scripts > to generate each of the 4 tarballs now used. > This is *NOT* a blocker, but at some point please also add the URL used in the scripts to the comments of the spec. Having it only in the script sort of obfuscates things. Feel free to do this in a future update, after the package is added to F19. > > $ /usr/lib/jvm/jre-1.8.0/bin/java -version > > openjdk version "1.8.0-internal" > > OpenJDK Runtime Environment (build 1.8.0-internal-0) > > OpenJDK 64-Bit Server VM (build 25.0-b20-internal, mixed mode) > > > > "internal"? I'm not sure what that means. As a tech preview this is > > probably not a big deal, but in case it's not on purpose I thought I'd > > mention it. > > "internal" is what the default build assumes is the version for any OpenJDK > build. I can tweak this, but not sure what a good (pre-release) version is. > Suggestions? Maybe s/internal/preview/ ? This is *NOT* a blocker, the package is fine with or without tweaking this. As for the rest that I snipped, you did more than was necessary to bring this up to snuff for packaging guidelines. Thanks!! And so: ================ *** APPROVED *** ================ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OfzHHXc1jD&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review