Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907007 --- Comment #8 from Luke Benstead <kazade@xxxxxxxxx> --- Just a few things to tweak: ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. - Upstream uses static libs [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [!]: Package requires other packages for directories it uses. - Need to add pkg-config [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/packager/review/907007-unittest++/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [!]: Requires correct, justified where necessary. - Need to add pkg-config [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 4 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Spec use %global instead of %define. Note: %define archivename unittest-cpp [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: unittest++-1.4-5.fc18.x86_64.rpm unittest++-devel-1.4-5.fc18.x86_64.rpm unittest++.x86_64: W: no-soname /usr/lib64/libUnitTest++.so unittest++-devel.x86_64: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities unittest++-devel.x86_64: W: spelling-error Summary(en_US) cpp -> cop, pp, cps unittest++-devel.x86_64: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities unittest++-devel.x86_64: W: spelling-error %description -l en_US cpp -> cop, pp, cps 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint unittest++-devel unittest++ unittest++-devel.x86_64: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities unittest++-devel.x86_64: W: spelling-error Summary(en_US) cpp -> cop, pp, cps unittest++-devel.x86_64: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities unittest++-devel.x86_64: W: spelling-error %description -l en_US cpp -> cop, pp, cps unittest++.x86_64: W: no-soname /usr/lib64/libUnitTest++.so unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so vtable for __cxxabiv1::__si_class_type_info unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so typeinfo for std::exception unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so typeinfo for std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> > unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::~basic_ostringstream() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::~basic_ostringstream() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so virtual thunk to std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::~basic_ostringstream() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so virtual thunk to std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::~basic_ostringstream() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so typeinfo for std::basic_ostream<char, std::char_traits<char> > unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostream<char, std::char_traits<char> >::~basic_ostream() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostream<char, std::char_traits<char> >::~basic_ostream() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so virtual thunk to std::basic_ostream<char, std::char_traits<char> >::~basic_ostream() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so virtual thunk to std::basic_ostream<char, std::char_traits<char> >::~basic_ostream() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so vtable for __cxxabiv1::__class_type_info unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so __cxa_pure_virtual unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::ios_base::Init::~Init() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so typeinfo for char const* unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so vtable for std::exception unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so __gxx_personality_v0 unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so operator delete(void*) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so __cxa_end_catch unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so __cxa_allocate_exception unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::~basic_ostringstream() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_string<char, std::char_traits<char>, std::allocator<char> >::find(char, unsigned long) const unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostream<char, std::char_traits<char> >& std::operator<< <std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_string<char, std::char_traits<char>, std::allocator<char> >::replace(unsigned long, unsigned long, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so __cxa_guard_release unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::basic_ostringstream(std::_Ios_Openmode) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::basic_ostringstream(std::_Ios_Openmode) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ios<char, std::char_traits<char> >::~basic_ios() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostream<char, std::char_traits<char> >::operator<<(float) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::~basic_ostringstream() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::allocator<char>::allocator() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_string<char, std::char_traits<char>, std::allocator<char> >::~basic_string() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ios<char, std::char_traits<char> >::basic_ios() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::str() const unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_string<char, std::char_traits<char>, std::allocator<char> >::operator=(char const*) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so __cxa_begin_catch unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so __cxa_rethrow unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostream<char, std::char_traits<char> >& std::operator<< <char, std::char_traits<char>, std::allocator<char> >(std::basic_ostream<char, std::char_traits<char> >&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so __cxa_throw unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::ios_base::Init::Init() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::exception::~exception() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_string<char, std::char_traits<char>, std::allocator<char> >::operator=(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_string<char, std::char_traits<char>, std::allocator<char> >::c_str() const unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so operator new(unsigned long) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so __cxa_guard_abort unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::__throw_length_error(char const*) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::basic_ostream<char, std::char_traits<char> >::operator<<(int) unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::__throw_bad_alloc() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so std::allocator<char>::~allocator() unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so __cxa_free_exception unittest++.x86_64: W: undefined-non-weak-symbol /usr/lib64/libUnitTest++.so __cxa_guard_acquire 2 packages and 0 specfiles checked; 0 errors, 60 warnings. # echo 'rpmlint-done:' Requires -------- unittest++-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config unittest++(x86-64) unittest++ (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) rtld(GNU_HASH) Provides -------- unittest++-devel: pkgconfig(unittest++) unittest++-devel unittest++-devel(x86-64) unittest++: libUnitTest++.so()(64bit) unittest++ unittest++(x86-64) Unversioned so-files -------------------- unittest++: /usr/lib64/libUnitTest++.so -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DykzVIamZs&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review