Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894834 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |erik-fedora@xxxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |erik-fedora@xxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #4 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> --- Taking for review * Why are you manually moving the .def files in the %build section? If the build fails without it, then this is most likely caused by a bug in the Makefile.am file which should be patched and reported upstream * Why is the %mingw_find_lang line commented out? If this package doesn't provide translations then please remove this line completely * The documentation can be removed as there's already a native gtkglext package in Fedora which provides these docs as well * The 'rm -rf $RPM_BUILD_ROOT' line isn't needed any more on modern environment and can be removed * The file containing the license should be added to the filelist for both packages and marked as %doc * Please update the summary for the main package so that it reflects the fact that this is a MinGW package -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PDYGfswDVN&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review