Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917330 --- Comment #4 from Conrad Meyer <konrad@xxxxxxxxxx> --- (In reply to comment #3) > Package Review ... > [x] = Pass [!] = Fail [-] = Not applicable[?] = Not evaluated > - Package contains BR: python2-devel or python3-devel > See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires Done. > - I can't find any copyright notice in this. Shouldn't the license be > Public Domain? The license I see is: "You may freely use this code in any way you can think of." Which, while quite permissive, does not say "this code is released into the public domain." So I think "copyright only" with basically unlimited license is more accurate than Public Domain. > - The definitions of python_sitelib is already present in current > Fedora, so remove the top lines (unless you are heading for EPEL, > looking at the rest of the spec I'm assuming you're not) Done. > - You have no actual way to indicate what version you have here - if > that file changes it would just be something like 0.2. I suggest you > treat this like a pre-release and adds a release tag indicating the > date, something like Release: 1.20130310%{?dist}. Sure, seems reasonable. My line of thought was that this was overkill for such a tiny library with dead upstream. Done. > ===== MUST items ===== > > Generic: > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "Unknown or generated". 1 files have unknown license. Detailed output of > licensecheck in /home/mk/FedoraReview/917330-python- > rsslib/licensecheck.txt Sorry, what's the issue here? > [!]: Package consistently uses macros (instead of hard-coded directory > names). > ----> See Issues on python_sitelib. (Done.) > [!]: Package is named according to the Package Naming Guidelines. > ---> See Issues on release tag. (Done.) > [-]: A package which is used by another package via an egg interface should > provide egg info. (N.B., this packaging creates a setup.py for this project and installs an egg.) New spec, SRPM. Bumped to 0-2.20130310, fixed BR on python2-devel, removed python_sitelib macro: http://konradm.fedorapeople.org/fedora/SPECS/python-rsslib.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-rsslib-0-2.20130310.fc17.src.rpm Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KUiMrlrr05&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review